Remove ReactViewGroup.getBackgroundColor()#47906
Closed
tdn120 wants to merge 1 commit intofacebook:mainfrom
Closed
Remove ReactViewGroup.getBackgroundColor()#47906tdn120 wants to merge 1 commit intofacebook:mainfrom
tdn120 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: There are no usages in the repo. External usages should be using [BackgroundStyleApplicator](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BackgroundStyleApplicator.kt#L82). Changelog: [Android][Breaking] Removed ReactViewGroup.getBackgroundColor() Differential Revision: D66368623
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66368623 |
Contributor
|
This pull request has been merged in 6a472c5. |
Collaborator
|
This pull request was successfully merged by Thomas Nardone in 6a472c5 When will my fix make it into a release? | How to file a pick request? |
1 task
kkafar
added a commit
to software-mansion/react-native-screens
that referenced
this pull request
Jan 31, 2025
) ## Description * facebook/react-native#45688 introduced `BackgroundStyleApplicator` * facebook/react-native#47906 removed our current accessor * somewhere along the way the `ColorDrawable` used previously by `ReactViewGroup` has been exchanged for `CompositeBackgroundDrawable` added in facebook/react-native#45688 > [!caution] ~This PR breaks compatibility with older versions of react-native. While this is fine on Fabric, this also breaks things for Paper.~ > ~Possible solution is to detect react native version in gradle and add versioned sourcesets with implementations for given react native versions.~ > > Not up to date. I've added versioned source files to ensure appropriate backward compatibility down to 0.74. > [!note] > We need CI to ensure the projects do build on all versions we support. ## Changes Migrated to `BackgroundStyleApplicator API` to resolve background color of `contentWrapper`. ## Test code and steps to reproduce `TestAndroidTransitions` - the form sheet should no longer be cut. ## Checklist - [ ] Ensured that CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There are no usages in the repo. External usages should be using BackgroundStyleApplicator.
Changelog: [Android][Breaking] Removed ReactViewGroup.getBackgroundColor()
Differential Revision: D66368623